From: Eduardo Habkost <ehabkost@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] kvm: qemu: don't fail building when pc-bios dir is empty
Date: Mon, 26 Jan 2009 13:57:34 -0200 [thread overview]
Message-ID: <20090126155734.GA16797@blackpad> (raw)
In-Reply-To: <20090126144636.GA9899@amt.cnet>
On Mon, Jan 26, 2009 at 12:46:36PM -0200, Marcelo Tosatti wrote:
> On Fri, Jan 23, 2009 at 04:41:33PM -0200, Eduardo Habkost wrote:
> > The '[ -f "$file" ] && install' command will make the return code
> > of the command to be non-zero, making 'make' abort. Use shell 'if'
> > construct instead.
> >
> > This patch also applies to the maint/2.6.29 branch.
>
> Hi Eduardo,
>
> Can you send this one to qemu upstream please?
qemu upstream doesn't have the '[ -f "$file" ]' conditional, so the fix
applies only to the kvm tree.
Maybe we could have the conditional (after fixing it) on qemu upstream,
but I am not sure about that.
--
Eduardo
next prev parent reply other threads:[~2009-01-26 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 18:41 [PATCH 0/3] kvm-userspace build and compat fixes Eduardo Habkost
2009-01-23 18:41 ` [PATCH 1/3] kvm: qemu: don't fail building when pc-bios dir is empty Eduardo Habkost
2009-01-26 14:46 ` Marcelo Tosatti
2009-01-26 15:57 ` Eduardo Habkost [this message]
2009-01-26 16:12 ` Marcelo Tosatti
2009-01-23 18:41 ` [PATCH 2/3] Use native anon_inodes on RHEL5 if available Eduardo Habkost
2009-01-23 18:41 ` [PATCH 3/3] compat code fixes for RHEL5 kernels Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126155734.GA16797@blackpad \
--to=ehabkost@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox