From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [PATCH 1/3] kvm: qemu: don't fail building when pc-bios dir is empty Date: Mon, 26 Jan 2009 13:57:34 -0200 Message-ID: <20090126155734.GA16797@blackpad> References: <1232736095-26244-1-git-send-email-ehabkost@redhat.com> <1232736095-26244-2-git-send-email-ehabkost@redhat.com> <20090126144636.GA9899@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39637 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbZAZP5k (ORCPT ); Mon, 26 Jan 2009 10:57:40 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0QFveR3026247 for ; Mon, 26 Jan 2009 10:57:40 -0500 Content-Disposition: inline In-Reply-To: <20090126144636.GA9899@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 26, 2009 at 12:46:36PM -0200, Marcelo Tosatti wrote: > On Fri, Jan 23, 2009 at 04:41:33PM -0200, Eduardo Habkost wrote: > > The '[ -f "$file" ] && install' command will make the return code > > of the command to be non-zero, making 'make' abort. Use shell 'if' > > construct instead. > > > > This patch also applies to the maint/2.6.29 branch. > > Hi Eduardo, > > Can you send this one to qemu upstream please? qemu upstream doesn't have the '[ -f "$file" ]' conditional, so the fix applies only to the kvm tree. Maybe we could have the conditional (after fixing it) on qemu upstream, but I am not sure about that. -- Eduardo