public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config
@ 2009-01-26 10:43 Mark McLoughlin
  2009-01-26 10:43 ` [PATCH 2/2] kvm: configure: --with-patched-kernel doesn't need kernelversion Mark McLoughlin
  2009-01-26 19:28 ` [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config Marcelo Tosatti
  0 siblings, 2 replies; 5+ messages in thread
From: Mark McLoughlin @ 2009-01-26 10:43 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: kvm, Mark McLoughlin

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index 493c178..1fd133c 100755
--- a/configure
+++ b/configure
@@ -126,7 +126,7 @@ if [ -n "$no_uname" ]; then
     elif [ -e "$kerneldir/include/config/kernel.release" ]; then
             depmod_version=`cat "$kerneldir/include/config/kernel.release"`
     elif [ -e "$kerneldir/.config" ]; then
-	depmod_version=$(awk '/Linux kernel version:/ { print $NF }'
+	depmod_version=$(awk '/Linux kernel version:/ { print $NF }' \
 			 "$kerneldir/.config")
     else
         echo
-- 
1.6.0.6


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] kvm: configure: --with-patched-kernel doesn't need kernelversion
  2009-01-26 10:43 [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config Mark McLoughlin
@ 2009-01-26 10:43 ` Mark McLoughlin
  2009-01-26 10:57   ` Glauber Costa
  2009-01-26 19:28 ` [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config Marcelo Tosatti
  1 sibling, 1 reply; 5+ messages in thread
From: Mark McLoughlin @ 2009-01-26 10:43 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: kvm, Mark McLoughlin

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index 1fd133c..c3910cd 100755
--- a/configure
+++ b/configure
@@ -119,7 +119,7 @@ if [ -d "$kerneldir/include2" ]; then
     kernelsourcedir=${kerneldir%/*}/source
 fi
 
-if [ -n "$no_uname" ]; then
+if [ -n "$no_uname" -a "$want_module" ]; then
     if [ -e "$kerneldir/.kernelrelease" ]; then
         depmod_version=`cat "$kerneldir/.kernelrelease"`
 
-- 
1.6.0.6


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] kvm: configure: --with-patched-kernel doesn't need kernelversion
  2009-01-26 10:43 ` [PATCH 2/2] kvm: configure: --with-patched-kernel doesn't need kernelversion Mark McLoughlin
@ 2009-01-26 10:57   ` Glauber Costa
  2009-01-26 11:10     ` Mark McLoughlin
  0 siblings, 1 reply; 5+ messages in thread
From: Glauber Costa @ 2009-01-26 10:57 UTC (permalink / raw)
  To: Mark McLoughlin; +Cc: Marcelo Tosatti, kvm

On Mon, Jan 26, 2009 at 8:43 AM, Mark McLoughlin <markmc@redhat.com> wrote:
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>

Why not?

I use it regularly to unequivocally define what kernel tree I'm using.
The default
is often not the right choice.



-- 
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] kvm: configure: --with-patched-kernel doesn't need kernelversion
  2009-01-26 10:57   ` Glauber Costa
@ 2009-01-26 11:10     ` Mark McLoughlin
  0 siblings, 0 replies; 5+ messages in thread
From: Mark McLoughlin @ 2009-01-26 11:10 UTC (permalink / raw)
  To: Glauber Costa; +Cc: Marcelo Tosatti, kvm

On Mon, 2009-01-26 at 08:57 -0200, Glauber Costa wrote:
> On Mon, Jan 26, 2009 at 8:43 AM, Mark McLoughlin <markmc@redhat.com> wrote:
> > Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> 
> Why not?
> 
> I use it regularly to unequivocally define what kernel tree I'm using.
> The default
> is often not the right choice.

It is only used by depmod when installing kvm.ko ... which we don't do
with --with-patched-kernel

Cheers,
Mark.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config
  2009-01-26 10:43 [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config Mark McLoughlin
  2009-01-26 10:43 ` [PATCH 2/2] kvm: configure: --with-patched-kernel doesn't need kernelversion Mark McLoughlin
@ 2009-01-26 19:28 ` Marcelo Tosatti
  1 sibling, 0 replies; 5+ messages in thread
From: Marcelo Tosatti @ 2009-01-26 19:28 UTC (permalink / raw)
  To: Mark McLoughlin; +Cc: kvm

Applied both, thanks.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-01-26 19:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-26 10:43 [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config Mark McLoughlin
2009-01-26 10:43 ` [PATCH 2/2] kvm: configure: --with-patched-kernel doesn't need kernelversion Mark McLoughlin
2009-01-26 10:57   ` Glauber Costa
2009-01-26 11:10     ` Mark McLoughlin
2009-01-26 19:28 ` [PATCH 1/2] kvm: configure: if all else fails, really infer kernel version from .config Marcelo Tosatti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox