From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: avi@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] Don't unregister unassigned PCI BAR
Date: Tue, 3 Feb 2009 09:26:59 -0200 [thread overview]
Message-ID: <20090203112659.GA5060@amt.cnet> (raw)
In-Reply-To: <20090203115819.GB30234@redhat.com>
On Tue, Feb 03, 2009 at 01:58:19PM +0200, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/qemu/hw/pci.c b/qemu/hw/pci.c
> index 04aecc2..a6d57e5 100644
> --- a/qemu/hw/pci.c
> +++ b/qemu/hw/pci.c
> @@ -213,7 +213,7 @@ static void pci_unregister_io_regions(PCIDevice *pci_dev)
>
> for(i = 0; i < PCI_NUM_REGIONS; i++) {
> r = &pci_dev->io_regions[i];
> - if (!r->size)
> + if (!r->size || r->addr == -1)
> continue;
> if (r->type == PCI_ADDRESS_SPACE_IO) {
> isa_unassign_ioport(r->addr, r->size);
> --
> Gleb.
ACK, please apply.
next prev parent reply other threads:[~2009-02-03 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 11:58 [PATCH] Don't unregister unassigned PCI BAR Gleb Natapov
2009-02-03 11:26 ` Marcelo Tosatti [this message]
2009-02-03 12:25 ` Avi Kivity
2009-02-12 1:35 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203112659.GA5060@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox