public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: avi@redhat.com, glommer@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] various fixes for CPU/PCI hotplug
Date: Tue, 3 Feb 2009 14:43:46 -0200	[thread overview]
Message-ID: <20090203164346.GA12956@amt.cnet> (raw)
In-Reply-To: <20090203140129.GC30234@redhat.com>

On Tue, Feb 03, 2009 at 04:01:29PM +0200, Gleb Natapov wrote:
> Hi,
> 
> The fixed problems are:
>  1) Disabled processor _STA method should return 0 (this fixes Vista's
>     resume after hibernate problem)
>  2) Disabled processor _MAT method should return disabled MADT entry
>     instead of 0
>  3) Fix number of hot pluggable CPUs to be 16

Breaks Win2k. See commit 18dcd6be77864842b42e3d4f88215a6832d1f01c.

>  4) Properly handle write to GPE STS register (write 1 should clear bit)
>  5) Generate interrupt only if corespondent EN bit is set
>  5) Use reserved STS bits from PIIX4 chipset to avoid clash in the
>     future.

Can you please split the patch in cpu / non cpu parts?

Looks good to me (the non cpu stuff). Glauber, can you ack the cpu hotplug ?

Thanks


  parent reply	other threads:[~2009-02-03 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 14:01 [PATCH] various fixes for CPU/PCI hotplug Gleb Natapov
2009-02-03 14:46 ` dima
2009-02-03 15:13   ` Gleb Natapov
2009-02-03 16:43 ` Marcelo Tosatti [this message]
2009-02-03 16:47   ` Gleb Natapov
2009-02-03 18:58 ` Glauber Costa
2009-02-03 19:11   ` Marcelo Tosatti
2009-02-03 20:27   ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090203164346.GA12956@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox