From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] various fixes for CPU/PCI hotplug
Date: Tue, 3 Feb 2009 14:43:46 -0200
Message-ID: <20090203164346.GA12956@amt.cnet>
References: <20090203140129.GC30234@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: avi@redhat.com, glommer@redhat.com, kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:42381 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752440AbZBCQn7 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 3 Feb 2009 11:43:59 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n13GhxKO011514
	for <kvm@vger.kernel.org>; Tue, 3 Feb 2009 11:43:59 -0500
Content-Disposition: inline
In-Reply-To: <20090203140129.GC30234@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Feb 03, 2009 at 04:01:29PM +0200, Gleb Natapov wrote:
> Hi,
> 
> The fixed problems are:
>  1) Disabled processor _STA method should return 0 (this fixes Vista's
>     resume after hibernate problem)
>  2) Disabled processor _MAT method should return disabled MADT entry
>     instead of 0
>  3) Fix number of hot pluggable CPUs to be 16

Breaks Win2k. See commit 18dcd6be77864842b42e3d4f88215a6832d1f01c.

>  4) Properly handle write to GPE STS register (write 1 should clear bit)
>  5) Generate interrupt only if corespondent EN bit is set
>  5) Use reserved STS bits from PIIX4 chipset to avoid clash in the
>     future.

Can you please split the patch in cpu / non cpu parts?

Looks good to me (the non cpu stuff). Glauber, can you ack the cpu hotplug ?

Thanks