From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] various fixes for CPU/PCI hotplug Date: Tue, 3 Feb 2009 18:47:47 +0200 Message-ID: <20090203164747.GC29674@redhat.com> References: <20090203140129.GC30234@redhat.com> <20090203164346.GA12956@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, glommer@redhat.com, kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55240 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbZBCQuO (ORCPT ); Tue, 3 Feb 2009 11:50:14 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n13Go9l9012965 for ; Tue, 3 Feb 2009 11:50:09 -0500 Content-Disposition: inline In-Reply-To: <20090203164346.GA12956@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Feb 03, 2009 at 02:43:46PM -0200, Marcelo Tosatti wrote: > On Tue, Feb 03, 2009 at 04:01:29PM +0200, Gleb Natapov wrote: > > Hi, > > > > The fixed problems are: > > 1) Disabled processor _STA method should return 0 (this fixes Vista's > > resume after hibernate problem) > > 2) Disabled processor _MAT method should return disabled MADT entry > > instead of 0 > > 3) Fix number of hot pluggable CPUs to be 16 > > Breaks Win2k. See commit 18dcd6be77864842b42e3d4f88215a6832d1f01c. > Actually 3 should be "Fix number of hot pluggable CPUs to be 15" :) What I mean is that I extended bitmask that we use to pass CPU hotplug event from 8 bits to 16 bits. I didn't add one more processor object to ACPI. > > 4) Properly handle write to GPE STS register (write 1 should clear bit) > > 5) Generate interrupt only if corespondent EN bit is set > > 5) Use reserved STS bits from PIIX4 chipset to avoid clash in the > > future. > > Can you please split the patch in cpu / non cpu parts? > OK. -- Gleb.