From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filtering Date: Fri, 6 Feb 2009 22:16:47 +0000 Message-ID: <200902062216.47990.paul@codesourcery.com> References: <20090206044853.3116.46699.stgit@kvm.aw> <200902061512.42261.paul@codesourcery.com> <1233943142.7026.1335.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mail.codesourcery.com ([65.74.133.4]:33287 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753017AbZBFWQw (ORCPT ); Fri, 6 Feb 2009 17:16:52 -0500 In-Reply-To: <1233943142.7026.1335.camel@lappy> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: > > There should be two interface points between the the vlan and the device: > > 1) The device can indicate that it only cares about incoming (vlan to > > device) packets sent to a subset of MAC addresses. > > 2) The vlan can request that a device discards outgoing (device to vlan) > > packets that don't match a subset of MAC addresses. > > > > Typically a emulated NIC will implement (1) and a host interface will > > implement (2). > > > > The generic vlan code should be responsible for using the information > > provided by (1) to set (2) appropriately. Remember that network devices > > can be hotplugged. > > Do you think it's worthwhile for the vlan to save and consolidate > filtering from multiple (1) sources to program (2)? My interface is > effectively short circuiting and letting the (1) agent set (2). As you > mention below, this is an optimization, so I think it's reasonable that > if we exceed a 1x1 configuration of (1)s and (2)s, we need to reset back > to a shared media model and do filtering in the (1) agent, which is how > I think we should handle hotplug. My point is that the devices themselves shouldn't know or care about this. Obviously a trivial implementation of combining multiple sources is to disable the filter if there is more than one other device. Paul