From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH 0/4] Arguments to skip boot menu and to hide bios output Date: Mon, 9 Feb 2009 08:44:49 +0000 Message-ID: <20090209084449.GB20629@redhat.com> References: <1233965825-17970-1-git-send-email-FOSS@AtlasTechnologiesInc.com> <498CCCA6.7030503@codemonkey.ws> <200902071320.40457.FOSS@atlastechnologiesinc.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Cory Fields Return-path: Received: from mx1.redhat.com ([66.187.233.31]:38186 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbZBIIox (ORCPT ); Mon, 9 Feb 2009 03:44:53 -0500 Content-Disposition: inline In-Reply-To: <200902071320.40457.FOSS@atlastechnologiesinc.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Feb 07, 2009 at 01:20:40PM -0500, Cory Fields wrote: > Thanks for the direction, will submit patches to the appropriate places. > > I messed around with extending the -boot syntax as you suggested, > but I think boot c,verbose=off,prompt=off is a little cumbersome. > boot c,quiet,noprompt seems cleaner. Thoughts? The rest of QEMU is converging on using the same name=val syntax for optional args, even for boolean args. Thus I think we should follow that pattern here too. If we pick sensible defaults, so these flags don't need to be specified most of the time, then its not a big deal Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|