From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2] report IRQ injection status to userspace.
Date: Wed, 11 Feb 2009 18:45:33 -0200 [thread overview]
Message-ID: <20090211204533.GA14668@amt.cnet> (raw)
In-Reply-To: <498701EC.7040703@redhat.com>
On Mon, Feb 02, 2009 at 04:23:40PM +0200, Avi Kivity wrote:
> Gleb Natapov wrote:
>> On Mon, Feb 02, 2009 at 04:04:55PM +0200, Avi Kivity wrote:
>>
>>> Gleb Natapov wrote:
>>>
>>>>> Right, I was thinking about
>>>>>
>>>>> if (irq >= 0 && irq < IOAPIC_NUM_PINS) {
>>>>>
>>>>> Should return MASKED if irq is outside the acceptable range?
>>>>>
>>>>>
>>>> Is this ever can be false? Should we BUG() if irq is out of range?
>>>>
>>>>
>>> Yes, the number ultimately comes from userspace.
>>>
>>>
>> So may be -EINVAL should be returned to userspace?
>>
>
> Mmm, not sure. An out-of-bounds number here could be caused by
> userspace generating the wrong irq line number, or by the guest
> misconfiguring interrupts.
>
> We should error out on userspace bugs, but not guest bugs.
I don't see this applied yet ?
prev parent reply other threads:[~2009-02-11 20:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 11:32 [PATCH v2] report IRQ injection status to userspace Gleb Natapov
2009-01-21 12:34 ` Gleb Natapov
2009-01-26 16:10 ` Marcelo Tosatti
2009-01-27 13:27 ` Gleb Natapov
2009-01-27 15:41 ` Marcelo Tosatti
2009-01-28 16:37 ` Gleb Natapov
2009-01-28 19:09 ` Marcelo Tosatti
2009-02-02 14:04 ` Avi Kivity
2009-02-02 14:03 ` Gleb Natapov
2009-02-02 14:23 ` Avi Kivity
2009-02-11 20:45 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211204533.GA14668@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox