Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter

Alex Williamson
2009-02-12T16:36:51Z

On Thu, 2009-02-12 at 16:26 +0000, Paul Brook wrote:
> > +static void virtio_net_vlan_client_added(void *opaque)
> >...
> > +static void virtio_net_vlan_client_removed(void *opaque)
>
> Why are these two different?
>
> It looks like what you really want is a callback for "Something changed,
> and you need to reset your MAC filter."

I think we'd end up with a race if we only had one callback. For
instance if "change" was the result of a vlan client being removed, the
tap would clear the filter and the nic would try to install a filter.
The results would be different based on the calling order.

Alex