From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 7/7] [V3] kvm: qemu: fix hot remove assigned device with iommu Date: Tue, 17 Feb 2009 22:48:37 -0300 Message-ID: <20090218014837.GC17925@amt.cnet> References: <715D42877B251141A38726ABF5CABF2C01959AFEBC@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "'Avi Kivity'" , "'kvm@vger.kernel.org'" , "'Mark McLoughlin'" To: "Han, Weidong" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45483 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbZBRBtR (ORCPT ); Tue, 17 Feb 2009 20:49:17 -0500 Content-Disposition: inline In-Reply-To: <715D42877B251141A38726ABF5CABF2C01959AFEBC@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Feb 13, 2009 at 05:49:49PM +0800, Han, Weidong wrote: > when hot remove the assigned device with iommu, it should > deassign it from guest and free it from qemu. > > assign_dev_update_irqs may not be invoked when hot add a device, > so need to assign irq after device assignment in > init_assigned_device. Weidong, Can you please test device assignment hotplug with the current tree? There was a qemu merge yesterday. Thanks