From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>
Subject: Re: [PATCH 01/02] ia64: Move the macro definitions related to MSI to one header file.
Date: Wed, 18 Feb 2009 20:02:58 -0300 [thread overview]
Message-ID: <20090218230258.GA28402@amt.cnet> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC22422A91C@pdsmsx503.ccr.corp.intel.com>
Looks good, should go through Tony's tree I believe.
On Wed, Feb 18, 2009 at 10:17:56AM +0800, Zhang, Xiantao wrote:
> Thanks, Tony! It should not break anything due to no changes about code logic. :)
>
> Avi,
> Could you help to commit the patches with Tony's Ack ? Thanks!
> Xiantao
>
>
> Luck, Tony wrote:
> >> For supporting kvm's MSI, we have to move some macros
> >> from ia64_msi.c out to avoide duplicate them. In addition,
> >> to keep them consistent with x86's , I also changed some
> >> macros' name. How do you think of the patch ? If you
> >> agree to the changes, could you add your Sign-off-by to
> >> the patch, and Avi may check-in it to kvm.git first to
> >> fix an emergent build issue for kvm/ia64. Thanks!
> >
> > Looks OK to me (I didn't test it, or even build it ... so I hope you
> > did!).
> >
> > Acked-by: Tony Luck <tony.luck@intel.com>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-18 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 7:46 [PATCH 01/02] ia64: Move the macro definitions related to MSI to one header file Zhang, Xiantao
2009-02-17 18:04 ` Luck, Tony
2009-02-18 2:17 ` Zhang, Xiantao
2009-02-18 23:02 ` Marcelo Tosatti [this message]
2009-02-19 1:17 ` Zhang, Xiantao
2009-02-24 10:11 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218230258.GA28402@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox