From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 1/4] KVM: Fix wrong usage of _IOR in assigned device interface Date: Fri, 20 Feb 2009 15:02:01 +0800 Message-ID: <200902201502.02082.sheng@linux.intel.com> References: <1234967203-6031-1-git-send-email-sheng@linux.intel.com> <1234967203-6031-2-git-send-email-sheng@linux.intel.com> <499C1EBF.60200@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga10.intel.com ([192.55.52.92]:50225 "EHLO fmsmga102.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751619AbZBTHCJ (ORCPT ); Fri, 20 Feb 2009 02:02:09 -0500 In-Reply-To: <499C1EBF.60200@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 18 February 2009 22:44:15 Avi Kivity wrote: > Sheng Yang wrote: > > _IOR for copy_to_user and _IOW for copy_from_user... > > > > Noticed by Avi. > > > > Signed-off-by: Sheng Yang > > --- > > include/linux/kvm.h | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > > index 2163b3d..d742cbf 100644 > > --- a/include/linux/kvm.h > > +++ b/include/linux/kvm.h > > @@ -469,10 +469,10 @@ struct kvm_irq_routing { > > _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone) > > #define KVM_UNREGISTER_COALESCED_MMIO \ > > _IOW(KVMIO, 0x68, struct kvm_coalesced_mmio_zone) > > -#define KVM_ASSIGN_PCI_DEVICE _IOR(KVMIO, 0x69, \ > > +#define KVM_ASSIGN_PCI_DEVICE _IOW(KVMIO, 0x69, \ > > struct kvm_assigned_pci_dev) > > #define KVM_SET_GSI_ROUTING _IOW(KVMIO, 0x6a, struct > > kvm_irq_routing) -#define KVM_ASSIGN_IRQ _IOR(KVMIO, 0x70, \ > > +#define KVM_ASSIGN_IRQ _IOW(KVMIO, 0x70, \ > > struct kvm_assigned_irq) > > #define KVM_REINJECT_CONTROL _IO(KVMIO, 0x71) > > KVM_ASSIGN_PCI_DEVICE was introduced in 2.6.28. We can't fix it since > it's part of the ABI. OK... So please take this one off. -- regards Yang, Sheng