From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg KH <greg@kroah.com>
Subject: Re: [PATCH 1/2] PCI: add some sysfs ABI docs
Date: Mon, 23 Feb 2009 19:47:18 -0800
Message-ID: <20090224034718.GA24780@kroah.com>
References: <1234542767.23746.81.camel@blaa> <20090214021244.GW27684@sequoia.sous-sol.org> <20090214033319.GA4591@kroah.com> <20090224012625.GA7436@sequoia.sous-sol.org> <20090224021725.GB7436@sequoia.sous-sol.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Mark McLoughlin <markmc@redhat.com>, kvm <kvm@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Chris Wright <chrisw@redhat.com>,
	"Dugger, Donald D" <donald.d.dugger@intel.com>,
	"Kay, Allen M" <allen.m.kay@intel.com>
To: Chris Wright <chrisw@sous-sol.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from kroah.org ([198.145.64.141]:60789 "EHLO coco.kroah.org"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1750881AbZBXDsK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 23 Feb 2009 22:48:10 -0500
Content-Disposition: inline
In-Reply-To: <20090224021725.GB7436@sequoia.sous-sol.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Feb 23, 2009 at 06:17:25PM -0800, Chris Wright wrote:
> Add sysfs ABI docs for driver entries bind, unbind and new_id.  These
> entries are pretty old, from 2.6.0 onwards AFAIK, so this documents
> current behaviour.
> 
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> ---
>  Documentation/ABI/testing/sysfs-bus-pci |   41 ++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> --- a/Documentation/ABI/testing/sysfs-bus-pci
> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -1,3 +1,44 @@
> +What:		/sys/bus/pci/drivers/.../bind
> +Date:		December 2003
> +Contact:	linux-pci@vger.kernel.org
> +Description:
> +		Writing a device location to this file will cause
> +		the driver to attempt to bind to the device found at
> +		this location.	This is useful for overriding default
> +		bindings.  The format for the location is: DDDD:BB:DD.F.
> +		That is Domain:Bus:Device.Function and is the same as
> +		found in /sys/bus/pci/devices/.  For example:
> +		# echo 0000:00:19.0 > /sys/bus/pci/drivers/foo/bind

Don't you need 'echo -n' instead?  Or did we fix that problem?  Or is
that just for the new_id file?

If so, feel free to ignore the comment and add:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

Thanks a lot for doing this, it is much needed.

greg k-h