From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH 1/2] PCI: add some sysfs ABI docs
Date: Mon, 23 Feb 2009 21:08:35 -0800
Message-ID: <20090224050835.GD7436@sequoia.sous-sol.org>
References: <1234542767.23746.81.camel@blaa> <20090214021244.GW27684@sequoia.sous-sol.org> <20090214033319.GA4591@kroah.com> <20090224012625.GA7436@sequoia.sous-sol.org> <20090224021725.GB7436@sequoia.sous-sol.org> <20090224034718.GA24780@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Chris Wright <chrisw@sous-sol.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Mark McLoughlin <markmc@redhat.com>, kvm <kvm@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Chris Wright <chrisw@redhat.com>,
	"Dugger, Donald D" <donald.d.dugger@intel.com>,
	"Kay, Allen M" <allen.m.kay@intel.com>
To: Greg KH <greg@kroah.com>
Return-path: <linux-pci-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20090224034718.GA24780@kroah.com>
Sender: linux-pci-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

* Greg KH (greg@kroah.com) wrote:
> On Mon, Feb 23, 2009 at 06:17:25PM -0800, Chris Wright wrote:
> > +		# echo 0000:00:19.0 > /sys/bus/pci/drivers/foo/bind
> 
> Don't you need 'echo -n' instead?  Or did we fix that problem?  Or is
> that just for the new_id file?

Not any more, bind/unbind using sysfs_streq now (I think as of 2.6.28).
And new_id doesn't need it either.

> If so, feel free to ignore the comment and add:
> 	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> Thanks a lot for doing this, it is much needed.