Re: [PATCH 2/2] PCI: add remove_id sysfs entry

Chris Wright
2009-02-24T05:33:13Z

* Greg KH (greg@kroah.com) wrote:
> On Mon, Feb 23, 2009 at 06:18:29PM -0800, Chris Wright wrote:
> > This adds a remove_id sysfs entry to allow users of new_id to later
> > remove the added dynid. One use case is management tools that want to
> > dynamically bind/unbind devices to pci-stub driver while devices are
> > assigned to KVM guests. Rather than having to track which driver was
> > originally bound to the driver, a mangement tool can simply:
> >
> > # echo "8086 10f5" > /sys/bus/pci/drivers/pci-stub/new_id
> > # echo -n 0000:00:19.0 > /sys/bus/pci/devices/0000:00:19.0/driver/unbind
> > # echo -n 0000:00:19.0 > /sys/bus/pci/drivers/pci-stub/bind
>
> Ah, you do need -n with unbind and bind, you might want to change your
> documentation :)

Heh, it is confusing. I'll just drop the -n from the changelog here,
and add a note to the docs that mention older kernels may need -n.

thanks,
-chris