Re: [PATCH 1/2] PCI: add some sysfs ABI docs

Greg KH
2009-02-24T03:48:10Z

On Mon, Feb 23, 2009 at 06:17:25PM -0800, Chris Wright wrote:
> Add sysfs ABI docs for driver entries bind, unbind and new_id. These
> entries are pretty old, from 2.6.0 onwards AFAIK, so this documents
> current behaviour.
>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> ---
> Documentation/ABI/testing/sysfs-bus-pci | 41 ++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> --- a/Documentation/ABI/testing/sysfs-bus-pci
> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -1,3 +1,44 @@
> +What: /sys/bus/pci/drivers/.../bind
> +Date: December 2003
> +Contact: linux-pci@vger.kernel.org
> +Description:
> + Writing a device location to this file will cause
> + the driver to attempt to bind to the device found at
> + this location. This is useful for overriding default
> + bindings. The format for the location is: DDDD:BB:DD.F.
> + That is Domain:Bus:Device.Function and is the same as
> + found in /sys/bus/pci/devices/. For example:
> + # echo 0000:00:19.0 > /sys/bus/pci/drivers/foo/bind

Don't you need 'echo -n' instead? Or did we fix that problem? Or is
that just for the new_id file?

If so, feel free to ignore the comment and add:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

Thanks a lot for doing this, it is much needed.

greg k-h