Re: [PATCH 1/2] PCI: add some sysfs ABI docs

Chris Wright
2009-02-24T05:08:35Z

* Greg KH (greg@kroah.com) wrote:
> On Mon, Feb 23, 2009 at 06:17:25PM -0800, Chris Wright wrote:
> > + # echo 0000:00:19.0 > /sys/bus/pci/drivers/foo/bind
>
> Don't you need 'echo -n' instead? Or did we fix that problem? Or is
> that just for the new_id file?

Not any more, bind/unbind using sysfs_streq now (I think as of 2.6.28).
And new_id doesn't need it either.

> If so, feel free to ignore the comment and add:
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> Thanks a lot for doing this, it is much needed.