Re: [PATCH 2/2 v2] PCI: add remove_id sysfs entry

Chris Wright
2009-02-27T00:27:27Z

* Han, Weidong (weidong.han@intel.com) wrote:
> Chris Wright wrote:
> > This adds a remove_id sysfs entry to allow users of new_id to later
> > remove the added dynid. One use case is management tools that want to
> > dynamically bind/unbind devices to pci-stub driver while devices are
> > assigned to KVM guests. Rather than having to track which driver was
> > originally bound to the driver, a mangement tool can simply:
> >
> > # echo "8086 10f5" > /sys/bus/pci/drivers/pci-stub/new_id
> > # echo 0000:00:19.0 > /sys/bus/pci/devices/0000:00:19.0/driver/unbind
> > # echo 0000:00:19.0 > /sys/bus/pci/drivers/pci-stub/bind
> >
> > Guest uses device
> >
> > # echo "8086 10f5" > /sys/bus/pci/drivers/pci-stub/remove_id
> > # echo 0000:00:19.0 > /sys/bus/pci/drivers_probe
>
> After above two commands, I found device 00:19.0 was still bound to pci-stub, and doesn't work. I found it needs following unbind command between remove_id and drivers_probe to make it work with original driver:
> # echo "8086 10f5" > /sys/bus/pci/drivers/pci-stub/unbind
>
> Chris, did it also happen on your side? or did I miss something?

You're right. I just forgot to put that in the changelog.

thanks,
-chris