From: Arnd Bergmann <arnd@arndb.de>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH] remove static declaration from wall clock version
Date: Thu, 26 Feb 2009 20:50:26 +0100 [thread overview]
Message-ID: <200902262050.27555.arnd@arndb.de> (raw)
In-Reply-To: <1235677340-3139-1-git-send-email-glommer@redhat.com>
On Thursday 26 February 2009, Glauber Costa wrote:
> @@ -548,15 +548,13 @@ static int do_set_msr(struct kvm_vcpu *vcpu, unsigned index, u64 *data)
>
> static void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock)
> {
> - static int version;
> + int version = 1;
> struct pvclock_wall_clock wc;
> struct timespec now, sys, boot;
>
> if (!wall_clock)
> return;
>
> - version++;
> -
> kvm_write_guest(kvm, wall_clock, &version, sizeof(version));
>
> /*
Doesn't this mean that kvm_write_guest now writes an uninitialized value
to the guest?
I think what you need here is a 'static atomic_t version;' so you can
do an atomic_inc instead of the ++.
Arnd <><
next prev parent reply other threads:[~2009-02-26 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 19:42 [PATCH] remove static declaration from wall clock version Glauber Costa
2009-02-26 19:50 ` Arnd Bergmann [this message]
2009-02-27 1:22 ` Glauber Costa
2009-02-27 1:28 ` Arnd Bergmann
2009-02-27 16:44 ` Marcelo Tosatti
2009-03-03 11:21 ` Marcelo Tosatti
2009-03-08 12:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902262050.27555.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox