* assigned dev msi int handling
@ 2009-02-26 23:59 Marcelo Tosatti
2009-02-27 4:26 ` Yang, Sheng
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2009-02-26 23:59 UTC (permalink / raw)
To: Yang, Sheng; +Cc: kvm-devel
Hi Sheng,
So for guest INTX interrupts the host interrupt is reenabled on ack from
the guest, which is nice. Now for guest MSI interrupts it keeps reenabling
the interrupt as fast as the work handler can run.
Can you explain why it works this way? Why not disable interrupts
on the host in all cases and only reenable on ack?
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: assigned dev msi int handling
2009-02-26 23:59 assigned dev msi int handling Marcelo Tosatti
@ 2009-02-27 4:26 ` Yang, Sheng
0 siblings, 0 replies; 2+ messages in thread
From: Yang, Sheng @ 2009-02-27 4:26 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: kvm-devel
On Friday 27 February 2009 07:59:27 Marcelo Tosatti wrote:
> Hi Sheng,
>
> So for guest INTX interrupts the host interrupt is reenabled on ack from
> the guest, which is nice. Now for guest MSI interrupts it keeps reenabling
> the interrupt as fast as the work handler can run.
>
> Can you explain why it works this way? Why not disable interrupts
> on the host in all cases and only reenable on ack?
>
Sorry for I didn't think it over... The direct reason is ack_irq binding with
kvm_set_irq() which is unnecessary for MSI/MSI-X. But enable(msi) after EOI
seems more proper here, though more changes are needed for MSI-X(seems we need
one ack notifier for one vector in MSI-X).
--
regards
Yang, Sheng
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-27 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-26 23:59 assigned dev msi int handling Marcelo Tosatti
2009-02-27 4:26 ` Yang, Sheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox