From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
kvm@vger.kernel.org
Subject: Re: [PATCH 04/10] Support for device capability
Date: Tue, 3 Mar 2009 09:42:07 -0300 [thread overview]
Message-ID: <20090303124207.GA15492@amt.cnet> (raw)
In-Reply-To: <1235982573-6932-5-git-send-email-sheng@linux.intel.com>
Hi Sheng,
On Mon, Mar 02, 2009 at 04:29:27PM +0800, Sheng Yang wrote:
> This framework can be easily extended to support device capability, like
> MSI/MSI-x.
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
> qemu/hw/pci.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qemu/hw/pci.h | 30 ++++++++++++++++++++
> 2 files changed, 115 insertions(+), 0 deletions(-)
>
> @@ -205,6 +215,15 @@ struct PCIDevice {
>
> /* Current IRQ levels. Used internally by the generic PCI code. */
> int irq_state[4];
> +
> + /* Device capability configuration space */
> + struct {
> + int supported;
> + uint8_t config[PCI_CAPABILITY_CONFIG_MAX_LENGTH];
> + unsigned int start, length;
> + PCICapConfigReadFunc *config_read;
> + PCICapConfigWriteFunc *config_write;
> + } cap;
> };
Why do you have a copy of the capabilities config space? Why not just
access PCIDevice->config directly?
next prev parent reply other threads:[~2009-03-03 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 8:29 [PATCH 0/10 v4] MSI/MSI-X capability in userspace Sheng Yang
2009-03-02 8:29 ` [PATCH 01/10] kvm: Replace force type convert with container_of() Sheng Yang
2009-03-02 8:29 ` [PATCH 02/10] Make device assignment depend on libpci Sheng Yang
2009-03-02 8:29 ` [PATCH 03/10] Figure out device capability Sheng Yang
2009-03-03 12:50 ` Marcelo Tosatti
2009-03-04 3:04 ` Sheng Yang
2009-03-02 8:29 ` [PATCH 04/10] Support for " Sheng Yang
2009-03-03 12:42 ` Marcelo Tosatti [this message]
2009-03-04 2:56 ` Sheng Yang
2009-03-04 13:57 ` Marcelo Tosatti
2009-03-02 8:29 ` [PATCH 05/10] kvm: user interface for MSI type irq routing Sheng Yang
2009-03-02 8:29 ` [PATCH 06/10] kvm: libkvm: allocate unused gsi for " Sheng Yang
2009-03-02 8:29 ` [PATCH 07/10] kvm: expose MSI capability to guest Sheng Yang
2009-03-02 8:29 ` [PATCH 08/10] Add MSI-X related macro to pci.c Sheng Yang
2009-03-02 8:29 ` [PATCH 09/10] kvm: add ioctl KVM_SET_MSIX_ENTRY_NR and KVM_SET_MSIX_ENTRY Sheng Yang
2009-03-02 8:29 ` [PATCH 10/10] kvm: enable MSI-X capabilty for assigned device Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303124207.GA15492@amt.cnet \
--to=mtosatti@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox