From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 1/1] kvm: fix irq 0 assignment Date: Tue, 3 Mar 2009 17:32:13 +0800 Message-ID: <200903031732.13426.sheng@linux.intel.com> References: <1236066849-12515-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from mga05.intel.com ([192.55.52.89]:24967 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753584AbZCCJcU (ORCPT ); Tue, 3 Mar 2009 04:32:20 -0500 In-Reply-To: <1236066849-12515-1-git-send-email-sheng@linux.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 03 March 2009 15:54:09 Sheng Yang wrote: > Shouldn't update assigned irq if host irq is 0, which means uninitialized > or don't support INTx. Withdraw this, another problems shows... -- regards Yang, Sheng > > Signed-off-by: Sheng Yang > --- > qemu/hw/device-assignment.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c > index b7cbcec..cfbf39d 100644 > --- a/qemu/hw/device-assignment.c > +++ b/qemu/hw/device-assignment.c > @@ -521,6 +521,10 @@ static int assign_irq(AssignedDevInfo *adev) > AssignedDevice *dev = adev->assigned_dev; > int irq, r = 0; > > + /* irq 0 means uninitialized */ > + if (dev->real_device.irq == 0) > + return 0; > + > irq = pci_map_irq(&dev->dev, dev->intpin); > irq = piix_get_irq(irq);