From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH] KVM: Fix assigned device with no irq Date: Tue, 3 Mar 2009 17:47:52 +0800 Message-ID: <200903031747.53086.sheng@linux.intel.com> References: <1236066559-12403-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti To: kvm@vger.kernel.org Return-path: Received: from mga09.intel.com ([134.134.136.24]:23423 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753555AbZCCJr7 (ORCPT ); Tue, 3 Mar 2009 04:47:59 -0500 In-Reply-To: <1236066559-12403-1-git-send-email-sheng@linux.intel.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 03 March 2009 15:49:19 Sheng Yang wrote: > Some device like VF of SRIOV only support MSI-X. > > With this patch, SRIOV can be enabled with KVM assigned device(all kernel > space patches are ready). > Withdraw this as well. -- regards Yang, Sheng > Signed-off-by: Sheng Yang > --- > virt/kvm/kvm_main.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 4d2be16..5dc6423 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -308,6 +308,10 @@ static int assigned_device_update_intx(struct kvm > *kvm, if (adev->irq_requested_type & KVM_ASSIGNED_DEV_HOST_INTX) > return 0; > > + /* IRQ 0 means uninitialized */ > + if (adev->host_irq == 0) > + return 0; > + > if (irqchip_in_kernel(kvm)) { > if (!msi2intx && > (adev->irq_requested_type & KVM_ASSIGNED_DEV_HOST_MSI)) { > @@ -529,9 +533,8 @@ static int kvm_vm_ioctl_assign_irq(struct kvm *kvm, > r = 0; > } else { > printk(KERN_WARNING > - "kvm: failed to enable MSI device!\n"); > - r = -ENOTTY; > - goto out_release; > + "kvm: device didn't support INTx or MSI!\n"); > + r = 0; > } > } else { > /* Non-sharing INTx mode */