* [PATCH 1/1] kvm: fix irq 0 assignment
@ 2009-03-03 7:54 Sheng Yang
2009-03-03 9:32 ` Sheng Yang
0 siblings, 1 reply; 3+ messages in thread
From: Sheng Yang @ 2009-03-03 7:54 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti; +Cc: kvm, Sheng Yang
Shouldn't update assigned irq if host irq is 0, which means uninitialized
or don't support INTx.
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
qemu/hw/device-assignment.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index b7cbcec..cfbf39d 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -521,6 +521,10 @@ static int assign_irq(AssignedDevInfo *adev)
AssignedDevice *dev = adev->assigned_dev;
int irq, r = 0;
+ /* irq 0 means uninitialized */
+ if (dev->real_device.irq == 0)
+ return 0;
+
irq = pci_map_irq(&dev->dev, dev->intpin);
irq = piix_get_irq(irq);
--
1.5.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] kvm: fix irq 0 assignment
2009-03-03 7:54 [PATCH 1/1] kvm: fix irq 0 assignment Sheng Yang
@ 2009-03-03 9:32 ` Sheng Yang
2009-03-03 10:40 ` Sheng Yang
0 siblings, 1 reply; 3+ messages in thread
From: Sheng Yang @ 2009-03-03 9:32 UTC (permalink / raw)
To: kvm; +Cc: Avi Kivity, Marcelo Tosatti
On Tuesday 03 March 2009 15:54:09 Sheng Yang wrote:
> Shouldn't update assigned irq if host irq is 0, which means uninitialized
> or don't support INTx.
Withdraw this, another problems shows...
--
regards
Yang, Sheng
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
> qemu/hw/device-assignment.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
> index b7cbcec..cfbf39d 100644
> --- a/qemu/hw/device-assignment.c
> +++ b/qemu/hw/device-assignment.c
> @@ -521,6 +521,10 @@ static int assign_irq(AssignedDevInfo *adev)
> AssignedDevice *dev = adev->assigned_dev;
> int irq, r = 0;
>
> + /* irq 0 means uninitialized */
> + if (dev->real_device.irq == 0)
> + return 0;
> +
> irq = pci_map_irq(&dev->dev, dev->intpin);
> irq = piix_get_irq(irq);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] kvm: fix irq 0 assignment
2009-03-03 9:32 ` Sheng Yang
@ 2009-03-03 10:40 ` Sheng Yang
0 siblings, 0 replies; 3+ messages in thread
From: Sheng Yang @ 2009-03-03 10:40 UTC (permalink / raw)
To: kvm; +Cc: Avi Kivity, Marcelo Tosatti
On Tuesday 03 March 2009 17:32:13 Sheng Yang wrote:
> On Tuesday 03 March 2009 15:54:09 Sheng Yang wrote:
> > Shouldn't update assigned irq if host irq is 0, which means uninitialized
> > or don't support INTx.
>
> Withdraw this, another problems shows...
This one itself is OK, seems the problem caused by kernel side...
--
regards
Yang, Sheng
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-03 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-03 7:54 [PATCH 1/1] kvm: fix irq 0 assignment Sheng Yang
2009-03-03 9:32 ` Sheng Yang
2009-03-03 10:40 ` Sheng Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox