From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: avi@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 3/3] Consolidate ioapic/ipi interrupt delivery logic.
Date: Wed, 4 Mar 2009 15:01:33 -0300 [thread overview]
Message-ID: <20090304180133.GB28180@amt.cnet> (raw)
In-Reply-To: <20090304133021.18081.35591.stgit@dhcp-1-237.tlv.redhat.com>
On Wed, Mar 04, 2009 at 03:30:22PM +0200, Gleb Natapov wrote:
> Use kvm_apic_match_dest() in kvm_get_intr_delivery_bitmask() instead
> of duplicating the same code. Use kvm_get_intr_delivery_bitmask() in
> apic_send_ipi() to figure out ipi destination instead of reimplementing
> the logic.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
> -struct kvm_vcpu *kvm_get_lowest_prio_vcpu(struct kvm *kvm, u8 vector,
> - unsigned long *bitmap)
> -{
> - struct kvm_lapic *apic;
> -
> - apic = kvm_apic_round_robin(kvm, vector, bitmap);
> - if (apic)
> - return apic->vcpu;
> - return NULL;
> + return vcpu1->arch.apic_arb_prio - vcpu2->arch.apic_arb_prio;
> }
Can you split the round robin logic change to a separate patch, and
have only code unification in this?
Also mind the tabs.
prev parent reply other threads:[~2009-03-04 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 13:30 [PATCH 0/3] ioapic/lapic/msi cleanup Gleb Natapov
2009-03-04 13:30 ` [PATCH 1/3] Make kvm_apic_set_irq() deliver all kinds of interrupts Gleb Natapov
2009-03-04 17:48 ` Marcelo Tosatti
2009-03-04 13:30 ` [PATCH 2/3] ioapic/msi interrupt delivery consolidation Gleb Natapov
2009-03-04 13:30 ` [PATCH 3/3] Consolidate ioapic/ipi interrupt delivery logic Gleb Natapov
2009-03-04 18:01 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304180133.GB28180@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox