From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 1/1] KVM: Merge kvm_ioapic_get_delivery_bitmask into kvm_get_intr_delivery_bitmask Date: Wed, 4 Mar 2009 15:30:09 -0300 Message-ID: <20090304183009.GA28982@amt.cnet> References: <200903041059.47652.sheng@linux.intel.com> <1236144782-7458-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, Gleb Natapov To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40676 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754233AbZCDSbD (ORCPT ); Wed, 4 Mar 2009 13:31:03 -0500 Content-Disposition: inline In-Reply-To: <1236144782-7458-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Mar 04, 2009 at 01:33:02PM +0800, Sheng Yang wrote: > Gleb fixed bitmap ops usage in kvm_ioapic_get_delivery_bitmask. > > Sheng merged two functions, as well as fixed several issues in > kvm_get_intr_delivery_bitmask > 1. deliver_bitmask is a bitmap rather than a unsigned long intereger. > 2. Lowest priority target bitmap wrong calculated by mistake. > 3. Prevent potential NULL reference. > 4. Declaration in include/kvm_host.h caused powerpc compilation warning. > 5. Add warning for guest broadcast interrupt with lowest priority delivery mode. > 6. Removed duplicate bitmap clean up in caller of kvm_get_intr_delivery_bitmask. > > Signed-off-by: Gleb Natapov > Signed-off-by: Sheng Yang > + bitmap_zero(deliver_bitmask, KVM_MAX_VCPUS); > + > + if (entry->fields.dest_mode == 0) { /* Physical mode. */ > + if (entry->fields.dest_id == 0xFF) { /* Broadcast. */ > + /* Lowest priority shouldn't combine with broadcast */ > + WARN_ON(entry->fields.delivery_mode == > + IOAPIC_LOWEST_PRIORITY); Applied with two changes: - printk(KERN_INFO) with printk_ratelimit instead of WARN. - bitmap_zero in the irq == 0 case. Thanks