From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] kvm : qemu : fix compilation error in kvm-userspace for ia64 Date: Wed, 4 Mar 2009 22:51:58 -0300 Message-ID: <20090305015158.GA31458@amt.cnet> References: <10C63FAD690C13458F0B32BCED571F1406D6778C@pdsmsx502.ccr.corp.intel.com> <20090303133231.GE15492@amt.cnet> <10C63FAD690C13458F0B32BCED571F1406D68376@pdsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" , Avi Kivity , "Zhang, Xiantao" To: "Zhang, Yang" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43156 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbZCEBwu (ORCPT ); Wed, 4 Mar 2009 20:52:50 -0500 Content-Disposition: inline In-Reply-To: <10C63FAD690C13458F0B32BCED571F1406D68376@pdsmsx502.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Mar 05, 2009 at 09:36:13AM +0800, Zhang, Yang wrote: > Marcelo Tosatti wrote: > > On Tue, Mar 03, 2009 at 11:38:17AM +0800, Zhang, Yang wrote: > >> diff --git a/qemu/hw/i8259.c b/qemu/hw/i8259.c > >> index 9cb3941..025f993 100644 > >> --- a/qemu/hw/i8259.c > >> +++ b/qemu/hw/i8259.c > >> @@ -189,8 +189,10 @@ static void i8259_set_irq(void *opaque, int > >> irq, int level) if (kvm_enabled()) { int pic_ret; > >> if (kvm_set_irq(irq, level, &pic_ret)) { > >> +#ifndef TARGET_IA64 > >> if (pic_ret != 0) > >> apic_set_irq_delivered(); > >> +#endif > > > > Why don't you define apic_set_irq_delivered for IA64? > > seems right, But i cannot find the proper place to define it. > And i think we can do this at the time of we need to use it. The thinking is avoid code from piling in kvm-userspace when it belongs in upstream QEMU. #ifdef's like that are ugly, but OK. Will apply. Can you please submit this one to be included in QEMU upstream? commit f759e44e04f03798d83de53d2c295965c68126a2 Author: Yang Date: Thu Jan 15 13:03:53 2009 +0800 kvm: qemu: Save ia64 nvram Thanks