From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 1/3] kvm: fix irq 0 assignment Date: Thu, 5 Mar 2009 10:47:04 +0800 Message-ID: <200903051047.04314.sheng@linux.intel.com> References: <1236153269-8825-1-git-send-email-sheng@linux.intel.com> <20090304193054.GA29032@amt.cnet> <20090304194141.GG10376@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Avi Kivity , kvm@vger.kernel.org To: Chris Wright Return-path: Received: from mga12.intel.com ([143.182.124.36]:24117 "EHLO azsmga102.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751010AbZCECrI (ORCPT ); Wed, 4 Mar 2009 21:47:08 -0500 In-Reply-To: <20090304194141.GG10376@x200.localdomain> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 05 March 2009 03:41:41 Chris Wright wrote: > * Marcelo Tosatti (mtosatti@redhat.com) wrote: > > Please do not special case irq 0. The fact that only x86/IA64 are > > supported at the moment does not mean other architectures can't > > use it. > > Seems logical to use a flag instead of overloading the irq value. > > > Also, the kernel code to handle dev/irq assignment is quite messy. It > > should be only a mechanism, with userspace controlling the policy. > > I really agree here. I think some work to simplify/clarify would be > time well-spent! So do I... After discussion with Marcelo, I would work with him on this clean up. :) -- regards Yang, Sheng