From: Gleb Natapov <gleb@redhat.com>
To: avi@redhat.com, marcelo@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH] do not free active mmu pages in free_mmu_pages()
Date: Wed, 11 Mar 2009 12:07:55 +0200 [thread overview]
Message-ID: <20090311100755.GA19724@redhat.com> (raw)
free_mmu_pages() should only undo what alloc_mmu_pages() does.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 2a36f7f..b625ed4 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -2638,14 +2638,6 @@ EXPORT_SYMBOL_GPL(kvm_disable_tdp);
static void free_mmu_pages(struct kvm_vcpu *vcpu)
{
- struct kvm_mmu_page *sp;
-
- while (!list_empty(&vcpu->kvm->arch.active_mmu_pages)) {
- sp = container_of(vcpu->kvm->arch.active_mmu_pages.next,
- struct kvm_mmu_page, link);
- kvm_mmu_zap_page(vcpu->kvm, sp);
- cond_resched();
- }
free_page((unsigned long)vcpu->arch.mmu.pae_root);
}
--
Gleb.
next reply other threads:[~2009-03-11 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 10:07 Gleb Natapov [this message]
2009-03-15 12:59 ` [PATCH] do not free active mmu pages in free_mmu_pages() Avi Kivity
2009-03-16 20:15 ` Marcelo Tosatti
2009-03-16 20:34 ` Gleb Natapov
2009-03-16 21:01 ` Marcelo Tosatti
2009-03-16 21:20 ` Gleb Natapov
2009-03-16 21:33 ` Marcelo Tosatti
2009-03-16 21:32 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311100755.GA19724@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcelo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox