Re: [PATCH] do not free active mmu pages in free_mmu_pages()

Gleb Natapov
2009-03-16T21:36:24Z

On Mon, Mar 16, 2009 at 06:33:22PM -0300, Marcelo Tosatti wrote:
> On Mon, Mar 16, 2009 at 11:20:10PM +0200, Gleb Natapov wrote:
> > > mmu_lock should be held there, and apparently it is not.
> > >
> > Yeah, my first solution was to add mmu_lock, but why function that gets
> > vcpu as an input should destroy data structure that is global for the VM.
>
> Point.
>
> > There is kvm_mmu_zap_all() that does same thing (well almost) and also does
> > proper locking. Shouldn't it be called during VM destruction instead?
>
> Yes, that would better (which happens implicitly with mmu notifiers
> ->release).
OK. I'll send new patch.

--
Gleb.