From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 1/2] Timer event should not unconditionally unhalt vcpu.
Date: Mon, 23 Mar 2009 13:50:19 -0300
Message-ID: <20090323165018.GB7773@amt.cnet>
References: <20090323101205.25798.69237.stgit@dhcp-1-237.tlv.redhat.com> <20090323131144.GH25518@redhat.com> <49C79C1A.6080102@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Gleb Natapov <gleb@redhat.com>, kvm@vger.kernel.org,
	"Yang, Sheng" <sheng.yang@intel.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:49402 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758769AbZCWQua (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 23 Mar 2009 12:50:30 -0400
Content-Disposition: inline
In-Reply-To: <49C79C1A.6080102@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Mar 23, 2009 at 04:26:34PM +0200, Avi Kivity wrote:
> Gleb Natapov wrote:
>> On Mon, Mar 23, 2009 at 12:12:06PM +0200, Gleb Natapov wrote:
>>   
>>> Currently timer events are processed before entering guest mode. Move it
>>> to main vcpu event loop since timer events should be processed even while
>>> vcpu is haled. Timer may cause interrupt/nmi to be injected and only then
>>> vcpu will be unhalted.
>>>
>>>     
>> Use this one instead. Previous broke -no-kvm-irqchip option.
>>   
>
> Looks good to me.  But this is tricky code.  Marcelo, Sheng, your opinions?

Looks good. Checking for timer interrupts after guest entry is strange,
but it can be changed in the future.