From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] kvm mmu: add support for 1GB pages in shadow paging
	code
Date: Sun, 29 Mar 2009 14:50:41 +0200
Message-ID: <20090329125041.GI31080@8bytes.org>
References: <1238164518-16261-1-git-send-email-joerg.roedel@amd.com> <49CF629E.9080403@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1757411AbZC2MvA@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <49CF629E.9080403@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Sun, Mar 29, 2009 at 02:59:26PM +0300, Avi Kivity wrote:
> Joerg Roedel wrote:
>>  	return write_protected;
>>  }
>>  @@ -789,11 +797,14 @@ static int kvm_handle_hva(struct kvm *kvm, 
>> unsigned long hva,
>>  		if (hva >= start && hva < end) {
>>  			gfn_t gfn_offset = (hva - start) >> PAGE_SHIFT;
>>  			unsigned long lidx = gfn_offset / KVM_PAGES_PER_2M_PAGE;
>> +			unsigned long hidx = gfn_offset / KVM_PAGES_PER_1G_PAGE;
>>  			retval |= handler(kvm, &memslot->rmap[gfn_offset],
>>  					  KVM_PAGE_SIZE_4k);
>>  			retval |= handler(kvm,
>>  					  &memslot->lpage_info[lidx].rmap_pde,
>>  					  KVM_PAGE_SIZE_2M);
>> +			retval |= handler(kvm, &memslot->hpage_info[hidx].rmap_pde,
>> +					  KVM_PAGE_SIZE_1G);
>>  		}
>>  	}
>>   
>
> Isn't this needed for tdp as well?

Hmm, yes. But it may be no problem not doing it because large pages are
never swapped out. Anyway, I will move this to the tdp patch

	Joerg