From: Ryan Harper <ryanh@us.ibm.com>
To: Uri Lublin <uril@redhat.com>
Cc: kvm@vger.kernel.org
Subject: [PATCH] kvm-autotest: kvm_vm.py get values from nic_params dict
Date: Thu, 2 Apr 2009 19:28:17 -0500 [thread overview]
Message-ID: <20090403002817.GA20681@us.ibm.com> (raw)
Looks like cut-n-paste error. We should be fetching values from
nic_params, not image params.
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com
diffstat output:
kvm_vm.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
diff --git a/client/tests/kvm_runtest_2/kvm_vm.py b/client/tests/kvm_runtest_2/kvm_vm.py
index 2e6599e..5136a26 100644
--- a/client/tests/kvm_runtest_2/kvm_vm.py
+++ b/client/tests/kvm_runtest_2/kvm_vm.py
@@ -189,8 +189,8 @@ class VM:
for nic_name in kvm_utils.get_sub_dict_names(params, "nics"):
nic_params = kvm_utils.get_sub_dict(params, nic_name)
qemu_cmd += " -net nic,vlan=%d" % vlan
- if image_params.get("nic_model"):
- qemu_cmd += ",model=%s" % image_params.get("nic_model")
+ if nic_params.get("nic_model"):
+ qemu_cmd += ",model=%s" % nic_params.get("nic_model")
qemu_cmd += " -net user,vlan=%d" % vlan
vlan += 1
reply other threads:[~2009-04-03 0:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090403002817.GA20681@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox