From: Ryan Harper <ryanh@us.ibm.com>
To: kvm@vger.kernel.org
Subject: [PATCH] kvm-userspace: fix option_rom_setup_reset address
Date: Thu, 2 Apr 2009 21:48:03 -0500 [thread overview]
Message-ID: <20090403024803.GC20681@us.ibm.com> (raw)
Commit f2b690ba461971fb8b04354de8717a73fd08b945 changed the target
address for option roms, but failed to use the same address when
registering an option rom reset. This manifests itself when using
extboot (boot=on) and reseting a guest via reboot or system_reset on
monitor and the guest fails to boot. This patch register the correct
region for each option rom.
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com
diffstat output:
pc.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
diff --git a/qemu/hw/pc.c b/qemu/hw/pc.c
index d4a4320..a649ecf 100644
--- a/qemu/hw/pc.c
+++ b/qemu/hw/pc.c
@@ -985,7 +985,7 @@ vga_bios_error:
before INT 19h. See the PNPBIOS specification, appendix B.
DDIM support is mandatory for proper PCI expansion ROM support. */
cpu_register_physical_memory(offset, size, option_rom_offset /* | IO_MEM_ROM */);
- option_rom_setup_reset(0xd0000 + offset, size);
+ option_rom_setup_reset(offset, size);
offset += size;
}
pci_option_rom_offset = offset;
reply other threads:[~2009-04-03 2:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090403024803.GC20681@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox