From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH 13/16] kvm: enable MSI-X capabilty for assigned device
Date: Tue, 7 Apr 2009 14:09:09 +0800
Message-ID: <200904071409.10361.sheng@linux.intel.com>
References: <1237261817-27955-1-git-send-email-sheng@linux.intel.com> <1237261817-27955-14-git-send-email-sheng@linux.intel.com> <1238794063.15558.402.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Cc: Alex Williamson <alex.williamson@hp.com>,
	Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	"Yunbiao (Ben) Lin" <ben.y.lin@intel.com>
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga09.intel.com ([134.134.136.24]:65164 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751244AbZDGGJV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 Apr 2009 02:09:21 -0400
In-Reply-To: <1238794063.15558.402.camel@lappy>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Saturday 04 April 2009 05:27:43 Alex Williamson wrote:
> On Tue, 2009-03-17 at 11:50 +0800, Sheng Yang wrote:
> > +    if (*ctrl_word & PCI_MSIX_ENABLE) {
> > +        if (assigned_dev_update_msix_mmio(pci_dev) < 0) {
> > +            perror("assigned_dev_update_msix_mmio");
> > +            return;
> > +        }
> > +        if (kvm_assign_irq(kvm_context, &assigned_irq_data) < 0) {
> > +            perror("assigned_dev_enable_msix: assign irq");
> > +            return;
> > +        }
> > +        assigned_dev->irq_requested_type = assigned_irq_data.flags;
> > +    }
> > +}
>
> Do we need some disable logic here?  If I toggle a bnx2 NIC in a guest,
> I get the following when it attempts to come back up:
>
> MSI-X entry number is zero!
> assigned_dev_update_msix_mmio: No such device or address

It seems that driver didn't fill the MMIO with any correct MSIX information, 
or the program fail to intercept it after driver set enable bit of MSIX. It's 
strange... (Have it got something to do with PM and some EXP feature you 
mentioned?)

Could you enable DEVICE_ASSSIGNMENT_DEBUG=1 in qemu/hw/device-assignment.c and 
post the output?

Thanks!

-- 
regards
Yang, Sheng


> Thanks,
>
> Alex
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html