From: Sheng Yang <sheng@linux.intel.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: Chris Wright <chrisw@sous-sol.org>, kvm <kvm@vger.kernel.org>
Subject: Re: [RFC PATCH] PCI pass-through fixups
Date: Tue, 7 Apr 2009 14:25:22 +0800 [thread overview]
Message-ID: <200904071425.23098.sheng@linux.intel.com> (raw)
In-Reply-To: <20090407000210.GL27148@sequoia.sous-sol.org>
On Tuesday 07 April 2009 08:02:10 Chris Wright wrote:
> * Alex Williamson (alex.williamson@hp.com) wrote:
> > I'm wondering if we need a spot for device specific fixups for PCI
> > pass-through. In the example below, I want to expose a single port of
> > an Intel 82571EB quad port copper NIC to a guest. It works great until
> > I shutdown the guest, at which point the guest e1000e driver knows by
> > the device ID that the NIC is a quad port, and blindly attempts to
> > twiddle some bits on the bridge above it (that doesn't exist).
>
> And what happens?
And the output of DEVICE_ASSIGNMENT_DEBUG=1 may help. And I don't have trouble
here with another dual/quad port card by Intel, but not 82571EB.
>
> > Obviously some robustness could be added to the driver, but would it
> > make sense to do something like below and automatically remap these
> > devices to identical single port device IDs? Thanks,
>
> Sounds quite fragile to me.
Same here... We'd better to know what's happened. (wow, you even know the
single port ones' device ID... :) )
--
regards
Yang, Sheng
next prev parent reply other threads:[~2009-04-07 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 20:16 [RFC PATCH] PCI pass-through fixups Alex Williamson
2009-04-07 0:02 ` Chris Wright
2009-04-07 6:25 ` Sheng Yang [this message]
2009-04-07 14:54 ` Chris Wright
2009-04-07 15:23 ` Alex Williamson
2009-04-07 15:47 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904071425.23098.sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=alex.williamson@hp.com \
--cc=chrisw@sous-sol.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox