public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH v3 03/10] Complete ljmp decoding at decode stage.
Date: Sun, 12 Apr 2009 13:36:25 +0300	[thread overview]
Message-ID: <20090412103625.16966.77083.stgit@trex.usersys.redhat.com> (raw)
In-Reply-To: <20090412103614.16966.89723.stgit@trex.usersys.redhat.com>

Signed-off-by: Gleb Natapov <gleb@redhat.com>
---

 arch/x86/kvm/x86_emulate.c |   25 +++++--------------------
 1 files changed, 5 insertions(+), 20 deletions(-)

diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index 71b4bee..8779cf2 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -193,7 +193,7 @@ static u32 opcode_table[256] = {
 	SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps,
 	/* 0xE8 - 0xEF */
 	ImplicitOps | Stack, SrcImm | ImplicitOps,
-	ImplicitOps, SrcImmByte | ImplicitOps,
+	SrcImm | Src2Imm16, SrcImmByte | ImplicitOps,
 	SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps,
 	SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps,
 	/* 0xF0 - 0xF7 */
@@ -1805,30 +1805,15 @@ special_insn:
 	}
 	case 0xe9: /* jmp rel */
 		goto jmp;
-	case 0xea: /* jmp far */ {
-		uint32_t eip;
-		uint16_t sel;
-
-		switch (c->op_bytes) {
-		case 2:
-			eip = insn_fetch(u16, 2, c->eip);
-			break;
-		case 4:
-			eip = insn_fetch(u32, 4, c->eip);
-			break;
-		default:
-			DPRINTF("jmp far: Invalid op_bytes\n");
-			goto cannot_emulate;
-		}
-		sel = insn_fetch(u16, 2, c->eip);
-		if (kvm_load_segment_descriptor(ctxt->vcpu, sel, 9, VCPU_SREG_CS) < 0) {
+	case 0xea: /* jmp far */
+		if (kvm_load_segment_descriptor(ctxt->vcpu, c->src2.val, 9,
+					VCPU_SREG_CS) < 0) {
 			DPRINTF("jmp far: Failed to load CS descriptor\n");
 			goto cannot_emulate;
 		}
 
-		c->eip = eip;
+		c->eip = c->src.val;
 		break;
-	}
 	case 0xeb:
 	      jmp:		/* jmp rel short */
 		jmp_rel(c, c->src.val);


  parent reply	other threads:[~2009-04-12 10:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-12 10:36 [PATCH v3 01/10] Add decoding of 16bit second immediate argument Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 02/10] Add lcall decoding Gleb Natapov
2009-04-12 10:36 ` Gleb Natapov [this message]
2009-04-12 10:36 ` [PATCH v3 04/10] Complete short/near jcc decoding in decode stage Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 05/10] Complete decoding of call near " Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 06/10] Add unsigned byte immediate decode Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 07/10] Completely decode in/out at decoding stage Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 08/10] Decode soft interrupt instructions Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 09/10] Add new mode of instruction emulation: skip Gleb Natapov
2009-04-12 10:37 ` [PATCH v3 10/10] [AMD] Skip instruction on a task switch only when appropriate Gleb Natapov
2009-04-12 11:43 ` [PATCH v3 01/10] Add decoding of 16bit second immediate argument Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090412103625.16966.77083.stgit@trex.usersys.redhat.com \
    --to=gleb@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox