From: Gleb Natapov <gleb@redhat.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org
Subject: [PATCH v3 10/10] [AMD] Skip instruction on a task switch only when appropriate.
Date: Sun, 12 Apr 2009 13:37:02 +0300 [thread overview]
Message-ID: <20090412103702.16966.9171.stgit@trex.usersys.redhat.com> (raw)
In-Reply-To: <20090412103614.16966.89723.stgit@trex.usersys.redhat.com>
If a task switch was initiated because off a task gate in IDT and IDT
was accessed because of an external even the instruction should not
be skipped.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
arch/x86/kvm/svm.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 3ffb695..053f3c5 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -1826,6 +1826,7 @@ static int task_switch_interception(struct vcpu_svm *svm,
int reason;
int int_type = svm->vmcb->control.exit_int_info &
SVM_EXITINTINFO_TYPE_MASK;
+ int int_vec = svm->vmcb->control.exit_int_info & SVM_EVTINJ_VEC_MASK;
tss_selector = (u16)svm->vmcb->control.exit_info_1;
@@ -1841,8 +1842,14 @@ static int task_switch_interception(struct vcpu_svm *svm,
reason = TASK_SWITCH_CALL;
- if (reason != TASK_SWITCH_GATE || int_type == SVM_EXITINTINFO_TYPE_SOFT)
- skip_emulated_instruction(&svm->vcpu);
+ if (reason != TASK_SWITCH_GATE ||
+ int_type == SVM_EXITINTINFO_TYPE_SOFT ||
+ (int_type == SVM_EXITINTINFO_TYPE_EXEPT &&
+ (int_vec == OF_VECTOR || int_vec == BP_VECTOR))) {
+ if (emulate_instruction(&svm->vcpu, kvm_run, 0, 0,
+ EMULTYPE_SKIP) != EMULATE_DONE)
+ return 0;
+ }
return kvm_task_switch(&svm->vcpu, tss_selector, reason);
}
next prev parent reply other threads:[~2009-04-12 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 10:36 [PATCH v3 01/10] Add decoding of 16bit second immediate argument Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 02/10] Add lcall decoding Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 03/10] Complete ljmp decoding at decode stage Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 04/10] Complete short/near jcc decoding in " Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 05/10] Complete decoding of call near " Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 06/10] Add unsigned byte immediate decode Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 07/10] Completely decode in/out at decoding stage Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 08/10] Decode soft interrupt instructions Gleb Natapov
2009-04-12 10:36 ` [PATCH v3 09/10] Add new mode of instruction emulation: skip Gleb Natapov
2009-04-12 10:37 ` Gleb Natapov [this message]
2009-04-12 11:43 ` [PATCH v3 01/10] Add decoding of 16bit second immediate argument Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090412103702.16966.9171.stgit@trex.usersys.redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox