From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: patch for virtual machine oriented scheduling(3) Date: Thu, 23 Apr 2009 14:39:39 +0300 Message-ID: <20090423113939.GI24095@redhat.com> References: <820ac2e90904220755u697ed443t60fb6dd36116bad3@mail.gmail.com> <20090423061528.GG24095@redhat.com> <820ac2e90904230434m6df48866y26343e6435621748@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: alex Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37766 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756443AbZDWLjn convert rfc822-to-8bit (ORCPT ); Thu, 23 Apr 2009 07:39:43 -0400 Content-Disposition: inline In-Reply-To: <820ac2e90904230434m6df48866y26343e6435621748@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Apr 23, 2009 at 07:34:46PM +0800, alex wrote: > On Thu, Apr 23, 2009 at 2:15 PM, Gleb Natapov wrote= : > > On Wed, Apr 22, 2009 at 10:55:24PM +0800, alex wrote: > >> the code for credit scheduler > >> ------------------------------------------------------------------= ----------------------------------------------------- > >> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > >> index 4d76bb6..9e88ff0 100644 > >> --- a/arch/x86/kvm/lapic.c > >> +++ b/arch/x86/kvm/lapic.c > >> @@ -284,7 +284,7 @@ int kvm_apic_match_dest(struct kvm_vcpu *vcpu, > >> struct kvm_lapic *source, > >> =9A =9A =9A =9A =9A =9A =9A =9A =9A "dest_mode 0x%x, short_hand 0x= %x\n", > >> =9A =9A =9A =9A =9A =9A =9A =9A =9A target, source, dest, dest_mod= e, short_hand); > >> > >> - =9A =9A =9A ASSERT(!target); > >> + =9A =9A =9A ASSERT(target); > > Did you mean it? >=20 > Yes. Then send it as separate patch please. > if target is not NULL, !target is 0, thus ASSERT(!target) will fail. >=20 > from the context(and from the runtime output), it is easy to see that > target should not be NULL. >=20 > previously, this did not cause any problem is that DEBUG is not defin= ed. > If you define DEBUG the head of file lapic.c, and run KVM, you will > find this bug. -- Gleb.