From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: kvm-85 won't boot guests with virtio block device Date: Fri, 24 Apr 2009 20:25:08 -0300 Message-ID: <20090424232508.GA15714@amt.cnet> References: <20090424171853.GA3798@polyware.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Pauline Middelink , Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41144 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbZDXXcH (ORCPT ); Fri, 24 Apr 2009 19:32:07 -0400 Content-Disposition: inline In-Reply-To: <20090424171853.GA3798@polyware.nl> Sender: kvm-owner@vger.kernel.org List-ID: Pauline, Good catch. Anthony, what is the reason for extboot not being upstream? On Fri, Apr 24, 2009 at 07:18:53PM +0200, Pauline Middelink wrote: > Hi, > > To follow up on the issues with kvm-85 and libvirt I discovered the following > issue: libvirt detects from the help of qemu which options it can give to > qemu. (in this case obviously /usr/kvm/bin/qemu-system-x86_64 -help) > > If you look carefully to the output of the -help of qemu from kvm-84 and > kvm-85, you will notice the boot flag to the -drive option has disappeared! > Hence letting libvirt believe it isnt allowed to use it, hence the unable > to boot error. > > A small patch which fixes the problem for me, is attached. > > Met vriendelijke groet, > Pauline Middelink Can you add a Signed-off-by: line so we can apply? > -- > GPG Key fingerprint = 2D5B 87A7 DDA6 0378 5DEA BD3B 9A50 B416 E2D0 C3C2 > For more details look at my website http://www.polyware.nl/~middelink > diff -ur kvm-85/qemu/qemu-options.hx kvm-85a/qemu/qemu-options.hx > --- kvm-85/qemu/qemu-options.hx 2009-04-21 11:57:31.000000000 +0200 > +++ kvm-85a/qemu/qemu-options.hx 2009-04-24 19:04:50.000000000 +0200 > @@ -77,6 +77,7 @@ > "-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i]\n" > " [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off]\n" > " [,cache=writethrough|writeback|none][,format=f][,serial=s]\n" > + " [,boot=on|off]\n" > " use 'file' as a drive image\n") > STEXI > @item -drive @var{option}[,@var{option}[,@var{option}[,...]]]