From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] qemu-kvm: add irqfd support
Date: Mon, 27 Apr 2009 13:47:43 +0300
Message-ID: <20090427104743.GA31112@redhat.com>
References: <20090424042756.1896.90317.stgit@dev.haskins.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, avi@redhat.com
To: Gregory Haskins <ghaskins@novell.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:43559 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752006AbZD0Ksq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 27 Apr 2009 06:48:46 -0400
Content-Disposition: inline
In-Reply-To: <20090424042756.1896.90317.stgit@dev.haskins.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Apr 24, 2009 at 12:30:17AM -0400, Gregory Haskins wrote:
> +int kvm_irqfd(kvm_context_t kvm, int gsi)
> +{
> +	int fd, r;
> +
> +	if (!kvm_check_extension(kvm, KVM_CAP_IRQFD))
> +		return -ENOENT;
> +
> +	fd = eventfd(0, 0);
> +	if (fd < 0)
> +		return fd;
> +
> +	r = assign_irqfd(kvm, fd, gsi);
> +	if (r < 0)
> +		return r;

Do we need to close fd on error?

> +
> +	return fd;
> +}