public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Hannes Reinecke <hare@suse.de>,
	kvm@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: SG_IO passthru support
Date: Mon, 27 Apr 2009 12:11:42 +0200	[thread overview]
Message-ID: <200904271211.42395.borntraeger@de.ibm.com> (raw)
In-Reply-To: <20090427082121.GA32488@lst.de>

Am Monday 27 April 2009 10:21:21 schrieben Sie:
> From: Hannes Reinecke <hare@suse.de>
> 
> Add support for SG_IO passthru to virtio_blk.  We add the scsi command
> block after the normal outhdr, and the scsi inhdr with full status
> information aswell as the sense buffer before the regular inhdr.
> 
> [hch: forward ported, added the VIRTIO_BLK_F_SCSI flags, some comments
>  and tested the whole beast]

I like the VIRTIO_BLK_F_SCSI flag - it avoids some problems we had with an
earlier version. (I believe we found a solution, but this explicit check
looks much more reliable)
I gave this patch a short test with the kuli loader (s390 userspace). You can
consider the "VIRTIO_BLK_F_SCSI not available" case
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>

Christian



  reply	other threads:[~2009-04-27 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27  8:21 [PATCH] virtio_blk: SG_IO passthru support Christoph Hellwig
2009-04-27 10:11 ` Christian Borntraeger [this message]
2009-05-05  3:13 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904271211.42395.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox