From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH 0/7] KVM support for 1GB pages v2
Date: Tue, 28 Apr 2009 12:20:54 +0200
Message-ID: <20090428102054.GX17438@amd.com>
References: <1240574327-21575-1-git-send-email-joerg.roedel@amd.com> <49F6D767.9050801@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Marcelo Tosatti <marcelo@kvack.or>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from outbound-dub.frontbridge.com ([213.199.154.16]:23403 "EHLO
	IE1EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759685AbZD1KgJ convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 28 Apr 2009 06:36:09 -0400
Content-Disposition: inline
In-Reply-To: <49F6D767.9050801@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Apr 28, 2009 at 01:16:07PM +0300, Avi Kivity wrote:
> Joerg Roedel wrote:
>> Hi,
>>
>> this is the second version of the patches implementing support for 1=
GB
>> pages in KVM. There are too many changes to the first version to men=
tion
>> them all here. The core support was rewritten to work with mapping
>> levels instead of page sizes. This was the main part of the change.
>> The patches still only support KVM with nested paging enabled
>
> What is missing to get shadow paging working with this?  I don't thin=
k =20
> it's particularly important (it will be pretty hard to find a GB page=
 =20
> without any shadowed pages in it), but I don't like arbitrary=20
> constraints.

1GB pages with shadow paging does not work yet. But I will post the
patch for it when it works stable for me. It makes sense at least if th=
e
guest uses 1gb pages in hugetlbfs.

> walk_addr() needs to change to support GB pages, did I miss it in the=
 =20
> patchset?

Ah true. I missed that in this patchset. I will add it.

Joerg

--=20
           | Advanced Micro Devices GmbH
 Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei M=FCnchen
 System    |=20
 Research  | Gesch=E4ftsf=FChrer: Jochen Polster, Thomas M. McCoy, Giul=
iano Meroni
 Center    | Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen
           | Registergericht M=FCnchen, HRB Nr. 43632