From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: kvm-kmod.git Date: Tue, 28 Apr 2009 13:34:09 +0300 Message-ID: <20090428103409.GC24494@redhat.com> References: <49F5A5DD.4090504@redhat.com> <20090428102030.GB24494@redhat.com> <49F6D96C.1060809@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: KVM list To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46257 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755053AbZD1KfL (ORCPT ); Tue, 28 Apr 2009 06:35:11 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3SAZBMU012496 for ; Tue, 28 Apr 2009 06:35:11 -0400 Content-Disposition: inline In-Reply-To: <49F6D96C.1060809@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Apr 28, 2009 at 01:24:44PM +0300, Avi Kivity wrote: > Michael S. Tsirkin wrote: >> On Mon, Apr 27, 2009 at 03:32:29PM +0300, Avi Kivity wrote: >> >>> This is a small git repository for the kvm external module kit. >>> >> >> So, I am building on a host with CONFIG_KVM_TRACE set in its >> kernel, but I run configure without enabling kvm trace. >> As a result the module fails to link: >> >> WARNING: "kvm_trace_ioctl" [/home/mtsirkin/scm/kvm-kmod/x86/kvm.ko] undefined! >> WARNING: "kvm_trace_cleanup" [/home/mtsirkin/scm/kvm-kmod/x86/kvm.ko] undefined! >> >> I think you need to undef CONFIG_KVM_TRACE somewhere to override the >> value set in autoconf.h? >> > > Or maybe, add a s/CONFIG_KVM_TRACE/CONFIG_KMOD_KVM_TRACE/ to make the > two options independent. You decide. I also wonder what happens if one tries to build on a machine with kvm built into kernel. Ideally one would get a clear error message. -- MST