From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
Anthony Liguori <anthony@codemonkey.ws>,
kvm@vger.kernel.org
Subject: Re: [PATCH RFC 0/8] virtio: add guest MSI-X support
Date: Tue, 28 Apr 2009 20:41:52 +0300 [thread overview]
Message-ID: <20090428174152.GA7604@redhat.com> (raw)
In-Reply-To: <49F6A672.8050704@redhat.com>
On Tue, Apr 28, 2009 at 09:47:14AM +0300, Avi Kivity wrote:
> Michael S. Tsirkin wrote:
>>> That saves us the new API (at the expense of a lot more code, but
>>> with added flexibility).
>>>
>>
>> So we'll probably need to rename request_vqs to request_vectors,
>> but we probably still need the driver to pass the number of
>> vectors it wants to the transport. Right?
>>
>>
>
> I don't think so - virtio will provide the number of interrupts it
> supports, and virtio-net will tell it to bind ring X to interrupt Y.
This does not work for MSIX - in linux, you must map all MSI-X entries
to interrupt vectors upfront.
So what I see is transports providing something like:
struct virtio_interrupt_mapping {
int virtqueue;
int interrupt;
};
map_vqs_to_interrupt(dev, struct virtio_interrupt_mapping *, int nvirtqueues);
unmap_vqs(dev);
--
MST
next prev parent reply other threads:[~2009-04-28 17:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 12:31 [PATCH RFC 0/8] virtio: add guest MSI-X support Michael S. Tsirkin
2009-04-27 14:00 ` Christian Borntraeger
2009-04-27 14:32 ` Michael S. Tsirkin
2009-04-27 15:37 ` Christian Borntraeger
2009-04-27 17:17 ` Michael S. Tsirkin
2009-04-27 15:06 ` Avi Kivity
2009-04-27 15:39 ` Michael S. Tsirkin
2009-04-27 16:59 ` Christian Borntraeger
2009-04-27 17:19 ` Michael S. Tsirkin
2009-04-28 6:47 ` Avi Kivity
2009-04-28 17:41 ` Michael S. Tsirkin [this message]
2009-04-28 17:51 ` Avi Kivity
2009-04-28 18:02 ` Michael S. Tsirkin
2009-04-28 19:56 ` Anthony Liguori
2009-04-28 21:01 ` Michael S. Tsirkin
2009-05-04 9:21 ` Avi Kivity
2009-05-04 11:54 ` Michael S. Tsirkin
2009-05-04 11:57 ` Avi Kivity
2009-04-27 14:39 ` Anthony Liguori
2009-04-27 17:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428174152.GA7604@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox