From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v2 00/16] interrupt injection rework Date: Wed, 29 Apr 2009 13:35:10 +0300 Message-ID: <20090429103510.GB19927@redhat.com> References: <1240325111-3725-1-git-send-email-gleb@redhat.com> <49F594CE.6050904@redhat.com> <49F81E46.2020104@siemens.com> <20090429102201.GA19927@redhat.com> <49F82CE5.6030100@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35465 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752550AbZD2KfO (ORCPT ); Wed, 29 Apr 2009 06:35:14 -0400 Content-Disposition: inline In-Reply-To: <49F82CE5.6030100@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 29, 2009 at 12:33:09PM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Wed, Apr 29, 2009 at 11:30:46AM +0200, Jan Kiszka wrote: > >> Avi Kivity wrote: > >>> Gleb Natapov wrote: > >>>> Hi, > >>>> > >>>> This patch series aims to consolidate IRQ injection code for in kernel > >>>> IRQ chip and userspace one. Also to move IRQ injection logic from > >>>> SVM/VMX specific code to x86.c. > >>>> > >>> Applied all, thanks for this excellent patchset. > >>> > >> Hmm, to which branch? Or did you just forget to also push it... > >> > >> Gleb, what is your current schedule regarding single-step on NMI iret? > >> > > I was going to look at it shortly. BTW there are other cases when single > > stepping is required. For instance if exception is injected and there is > > NMI pending NMI should be injected immediately after exception handler > > is started, but currently it happens only after a next exit. > > So we basically need an NMI windows notification that not only triggers > on iret completion. Sounds OK. > But we don't have one on SVM :( > Then I would say: once there is anything to test, even if it's early > stuff, throw it over. > OK. -- Gleb.