public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Gregory Haskins <ghaskins@novell.com>,
	kvm@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	avi@redhat.com
Subject: Re: [KVM PATCH v3 2/2] kvm: add support for irqfd via eventfd-notification interface
Date: Sun, 3 May 2009 21:31:11 +0100	[thread overview]
Message-ID: <20090503203111.GB8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.0905031252540.7899@makko.or.mcafeemobile.com>

On Sun, May 03, 2009 at 01:11:39PM -0700, Davide Libenzi wrote:
> On Sun, 3 May 2009, Al Viro wrote:
> 
> > IOW, the sane solution would be to export something that returns your
> > struct file *.  And stop playing with fd completely.
> 
> This builds but it's not tested at all.
> 
> - Make all the work of the old anon_inode_getfd(), done by a new 
>   anon_inode_getfile(), with anon_inode_getfd() using its services
> 
> - Make all the work done by sys_eventfd(), done by a new 
>   eventfd_file_create() (which in turn uses anon_inode_getfile()), with 
>   sys_eventfd() using its services
> 
> IRQfd can use eventfd_file_create(), fget(), get_unused_fd_flags() and 
> fd_install() just before returning.
> Is that what you had in mind?

More or less, but I'd like to see the irqfd side of that...

  reply	other threads:[~2009-05-03 20:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 18:33 [KVM PATCH v3 0/2] irqfd Gregory Haskins
2009-04-27 18:33 ` [KVM PATCH v3 1/2] eventfd: export fget and signal interfaces for module use Gregory Haskins
2009-04-27 18:33 ` [KVM PATCH v3 2/2] kvm: add support for irqfd via eventfd-notification interface Gregory Haskins
2009-04-30 13:07   ` Michael S. Tsirkin
2009-05-03 16:59     ` Avi Kivity
2009-05-03 19:04       ` Michael S. Tsirkin
2009-05-03 19:17         ` Avi Kivity
2009-05-03 19:25           ` Michael S. Tsirkin
2009-05-03  6:44   ` Al Viro
2009-05-03 18:07     ` Davide Libenzi
2009-05-03 19:01       ` Al Viro
2009-05-03 19:22         ` file descriptor abuses Al Viro
2009-05-03 20:11         ` [KVM PATCH v3 2/2] kvm: add support for irqfd via eventfd-notification interface Davide Libenzi
2009-05-03 20:31           ` Al Viro [this message]
2009-04-29  6:10 ` [KVM PATCH v3 0/2] irqfd Andrew Morton
2009-04-29  8:18   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090503203111.GB8633@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=avi@redhat.com \
    --cc=davidel@xmailserver.org \
    --cc=ghaskins@novell.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox