From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] Assign the correct pci id range to virtio_pci Date: Mon, 4 May 2009 11:23:32 +0930 Message-ID: <200905041123.33458.rusty@rustcorp.com.au> References: <1240571860-13832-1-git-send-email-pktoss@gmail.com> <49F4FFE8.9010603@codemonkey.ws> <1295ed070904262023h5efc21a3u768960d3f246fc2d@mail.gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Avi Kivity , kvm@vger.kernel.org To: Pantelis Koukousoulas Return-path: Received: from ozlabs.org ([203.10.76.45]:53868 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbZEDBxp (ORCPT ); Sun, 3 May 2009 21:53:45 -0400 In-Reply-To: <1295ed070904262023h5efc21a3u768960d3f246fc2d@mail.gmail.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 27 Apr 2009 12:53:25 pm Pantelis Koukousoulas wrote: > On Mon, Apr 27, 2009 at 3:44 AM, Anthony Liguori wrote: > > Would be good to at least include the "experiment range" in case people are > > making third-party virtio modules and want to play around without replacing > > virtio-{pci,*}. > > I 'd be happy with a simple comment explaining the 0x103f (e.g., > /* Not yet using the full 0x1000 - 0x10ef to hedge our bets in case we > broke the ABI.*/ > as explained above) Thanks, I like your patch. Where did this idea of "experimental" range come from, BTW? I prefer your module cmdline approach, as it discourages deployment with such numbers. Thanks, Rusty.