From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/8] virtio: add request_vqs/free_vqs operations Date: Mon, 4 May 2009 14:51:43 +0300 Message-ID: <20090504115143.GA30001@redhat.com> References: <20090427123153.GA1156@redhat.com> <200905042102.21218.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: virtualization@lists.linux-foundation.org, Anthony Liguori , kvm@vger.kernel.org, avi@redhat.com To: Rusty Russell Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34992 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753513AbZEDLxy (ORCPT ); Mon, 4 May 2009 07:53:54 -0400 Content-Disposition: inline In-Reply-To: <200905042102.21218.rusty@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 04, 2009 at 09:02:20PM +0930, Rusty Russell wrote: > On Mon, 27 Apr 2009 10:01:53 pm Michael S. Tsirkin wrote: > > This adds 2 new optional virtio operations: request_vqs/free_vqs. They will be > > used for MSI support, because MSI needs to know the total number of vectors > > upfront. > > > > Signed-off-by: Michael S. Tsirkin > > Hi Michael, Hi Rusty, > Thanks for this work! But this interface is horrible. Either probe for the > number of vqs in virtio_pci, or change find_vq to > > int (*find_vqs)(struct virtio_device *, unsigned max, > struct virtqueue *vqs[]); I'm happier with the later option: it's easy for a host to expose support for a very large number of vqs, and I don't want them to waste resources if guest does not use them. Thanks for the feedback! > Thanks, > Rusty. -- MST