From: Glauber Costa <glommer@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, ehabkost@redhat.com
Subject: Re: [PATCH 1/2] don't start cpu main loop while there is still init work to do.
Date: Mon, 4 May 2009 11:44:11 -0300 [thread overview]
Message-ID: <20090504144411.GH12844@poweredge.glommer> (raw)
In-Reply-To: <49FEFCB6.5070906@redhat.com>
On Mon, May 04, 2009 at 05:33:26PM +0300, Avi Kivity wrote:
> Glauber Costa wrote:
>>> I'd like to avoid vcpu ioctls from more than one thread, in case we
>>> ever move to a syscall implementation.
>>>
>>
>> Although I don't see exactly what's your point in here.
>> We're just adding a serialization points through pthreads function, not doing any ioctl from
>> the outside.
>>
>
> Doesn't the lapic creation call KVM_CREATE_LAPIC?
Oh yeah, that.
Maybe we could then move kvm_vcpu_init to the end of pc_new_cpu.
This way we don't break the separability of pc and x86 concepts. We would then issue the lapic creation
ioctl right after the vcpu is created.
How would you feel about it?
next prev parent reply other threads:[~2009-05-04 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 20:31 [PATCH 0/2] Fix cpu hotplug in upstream kvm Glauber Costa
2009-04-29 20:31 ` [PATCH 1/2] don't start cpu main loop while there is still init work to do Glauber Costa
2009-04-29 20:31 ` [PATCH 2/2] Present kvm with corret apic phys id Glauber Costa
2009-05-04 8:32 ` Avi Kivity
2009-05-04 8:30 ` [PATCH 1/2] don't start cpu main loop while there is still init work to do Avi Kivity
2009-05-04 14:26 ` Glauber Costa
2009-05-04 14:33 ` Avi Kivity
2009-05-04 14:44 ` Glauber Costa [this message]
2009-05-04 14:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504144411.GH12844@poweredge.glommer \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox