Re: [PATCH 1/8] virtio: add request_vqs/free_vqs operations

Rusty Russell
2009-05-04T11:32:31Z

On Mon, 27 Apr 2009 10:01:53 pm Michael S. Tsirkin wrote:
> This adds 2 new optional virtio operations: request_vqs/free_vqs. They will be
> used for MSI support, because MSI needs to know the total number of vectors
> upfront.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Hi Michael,

Thanks for this work! But this interface is horrible. Either probe for the
number of vqs in virtio_pci, or change find_vq to

int (*find_vqs)(struct virtio_device *, unsigned max,
struct virtqueue *vqs[]);

Thanks,
Rusty.